Looking for more bugs (fixing those bugs)

I've been looking around in generally the same area of GitHub (namely Mozilla/Network) to see if they have anymore issues that I can help with,

I've found one that seems to link to another GitHub project from Mozilla so it looks like a good place to continue my journey in open source

https://github.com/mozilla/foundation.mozilla.org/issues/235

modifications seem to need to take place in the mofo-bootstrap repo in order to apply more seamlessly into all their sites so I've made opened an issue on that repo to see if I can get things rolling.

https://github.com/mozilla/mofo-bootstrap/issues/122

Someone replied and stated that the code was already in for the Network part and all that needed to be done was change a few links and strings, I do plan on changing the Class name to match so that will have to be changed at a later time, after I've changed the class name.

as for the bootstrap part they were using a package called pug to store their urls in a scss file which made them look very strange

like so



turns out they had another file that pug used to convert to that syntax so I don't have to convert it manually (as in parts of the scss is program generated)

my pull requests for "Network" and "mofo-bootstrap" respectively
https://github.com/mozilla/foundation.mozilla.org/pull/927
https://github.com/mozilla/mofo-bootstrap/pull/123

BOTH PRs were Merged and closed =D

Comments

Post a Comment

Popular posts from this blog

#Python-dev: adding pathlike functionality

Image
https://bugs.python.org/issue32642 https://github.com/python/cpython/pull/5691 I've been working with the import library, adding a pathlike object function for sys.path, after making some changes I needed to run "make regen-importlib" to update the importlib_external.h, to allow the changes to go through since I'm modifying a core lib. after testing some I realized something was off, considering one of the tests was taking over 41 hours to complete, I started off by checking for conflicts to see if I was behind on some update they may have done to fix this down the line.... turns out my import library source code (not the .h) was out of date from the current version which caused a merge conflict in on the PR, which also caused appveyor to break, I fixed it easily by using Atom and clicking the "fix  conflict button, which created a dropdown menu of which one to keep, "use ours" vs "use theirs", then after selecting the appropriate one
Read more

Building Firefox on Linux first time build

Image
My first attempt at building Firefox: currently building it on a Linux distro known as Ubuntu, many linux users will recognize it as it can be considered mainstream. first issue I encountered is that my update URLs in my Ubuntu system was out of date and was getting 404 errors for some of them so I disabled them from the "other software" tab in the Ubuntu software settings screen. the update now works and it's currently installing Modern Mercurial via pip running it as normal and configuring it with preferred settings. watchman filesystem couldn't be found... firefoxtree enabled installing hg wip alias selecting MozReview only (requests bugzilla email address, can't do at the moment) cloning firefox now build had issues do to me running things as root, don't do that  [Error No 13] Permission denied issues resolved and it took around 81min to build, not bad for an old laptop. runs successfully =D made some modifications and rebuil
Read more

#Brave-laptop dev: interesting issue part 2

Image
This is a continuation from my previous blog, I've done further investigation and discovered that the favicon was being invalidated (redownloaded) every frame. and upon further investigation I found that the response header contained the following I did some research and found that modifying this is no easy task and that this setting forces the Favicon to be redownloaded  every time it's updated. Which in this case was every frame since it was being redrawn along with the gradient affect that follows the mouse. My attempts at figuring out how to modify the layer that the favicon is being drawn in is falling flat so far. I got some feedback from some of the brave developers on how to proceed after I declared these findings, that the issue can be resolved by manually saving the image as a URI and adding it to the CSS, but I haven't been able figure out how to convert a image to an URI.
Read more